Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Silently fail maybeInstrument #14140

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

chargome
Copy link
Member

We have some cases where certain instrumentations fails while patching (e.g. xhr).
This PR wraps the patching of these functions in a try catch to fail silently and log an error so we don't break user's apps.

relates to #14077

@chargome chargome self-assigned this Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.76 KB +0.08% +17 B 🔺
@sentry/browser - with treeshaking flags 21.54 KB +0.03% +6 B 🔺
@sentry/browser (incl. Tracing) 35.15 KB +0.04% +13 B 🔺
@sentry/browser (incl. Tracing, Replay) 71.87 KB +0.03% +18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.3 KB +0.01% +4 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.19 KB +0.03% +21 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.99 KB +0.03% +19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.83 KB +0.03% +19 B 🔺
@sentry/browser (incl. metrics) 27 KB +0.06% +16 B 🔺
@sentry/browser (incl. Feedback) 39.9 KB +0.04% +15 B 🔺
@sentry/browser (incl. sendFeedback) 27.4 KB +0.05% +14 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.2 KB +0.05% +16 B 🔺
@sentry/react 25.51 KB +0.06% +14 B 🔺
@sentry/react (incl. Tracing) 38.12 KB +0.04% +12 B 🔺
@sentry/vue 26.9 KB +0.06% +14 B 🔺
@sentry/vue (incl. Tracing) 37.04 KB +0.04% +14 B 🔺
@sentry/svelte 22.9 KB +0.07% +16 B 🔺
CDN Bundle 24.1 KB +0.03% +5 B 🔺
CDN Bundle (incl. Tracing) 36.97 KB +0.02% +6 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.63 KB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.97 KB +0.01% +7 B 🔺
CDN Bundle - uncompressed 70.66 KB +0.03% +18 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 109.73 KB +0.02% +18 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.25 KB +0.01% +18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.46 KB +0.01% +18 B 🔺
@sentry/nextjs (client) 38.2 KB +0.05% +19 B 🔺
@sentry/sveltekit (client) 35.75 KB +0.02% +6 B 🔺
@sentry/node 129.62 KB +0.02% +20 B 🔺
@sentry/node - without tracing 94.31 KB +0.02% +12 B 🔺
@sentry/aws-serverless 105.18 KB +0.02% +17 B 🔺

View base workflow run

@chargome chargome requested a review from andreiborza October 30, 2024 16:46
@chargome chargome marked this pull request as ready for review October 30, 2024 16:56
@chargome chargome requested a review from mydea October 30, 2024 16:56
@chargome
Copy link
Member Author

the size checks seems off

@chargome chargome merged commit 6729214 into develop Nov 4, 2024
147 checks passed
@chargome chargome deleted the cg/catch-instrumentation branch November 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants