fix(node): Make sure modulesIntegration does not crash esm apps

[AbhiPrasad]

resolves #12500
resolves #14165

modulesIntegration uses top-level require which will crash ESM apps if you explicitly import and use the integration.

// index.mjs
Sentry.init({
    dsn: '__DSN__',
    integrations: [
        Sentry.modulesIntegration(),
    ]
});

This fixes that by adding a boolean check for cjs apps, and logging out a warning as a result.

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	22.76 KB	-	-
@sentry/browser - with treeshaking flags	21.54 KB	-	-
@sentry/browser (incl. Tracing)	35.15 KB	-	-
@sentry/browser (incl. Tracing, Replay)	71.87 KB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	62.3 KB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	76.19 KB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	88.99 KB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)	90.83 KB	-	-
@sentry/browser (incl. metrics)	27 KB	-	-
@sentry/browser (incl. Feedback)	39.9 KB	-	-
@sentry/browser (incl. sendFeedback)	27.4 KB	-	-
@sentry/browser (incl. FeedbackAsync)	32.2 KB	-	-
@sentry/react	25.51 KB	-	-
@sentry/react (incl. Tracing)	38.12 KB	-	-
@sentry/vue	26.9 KB	-	-
@sentry/vue (incl. Tracing)	37.04 KB	-	-
@sentry/svelte	22.9 KB	-	-
CDN Bundle	24.1 KB	-	-
CDN Bundle (incl. Tracing)	36.97 KB	-	-
CDN Bundle (incl. Tracing, Replay)	71.63 KB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	76.97 KB	-	-
CDN Bundle - uncompressed	70.66 KB	-	-
CDN Bundle (incl. Tracing) - uncompressed	109.73 KB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	222.25 KB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	235.46 KB	-	-
@sentry/nextjs (client)	38.2 KB	-	-
@sentry/sveltekit (client)	35.75 KB	-	-
@sentry/node	129.68 KB	+0.05%	+60 B 🔺
@sentry/node - without tracing	94.4 KB	+0.09%	+85 B 🔺
@sentry/aws-serverless	105.24 KB	+0.06%	+60 B 🔺

View base workflow run

[timfish]

I don't think we can rely on checking at integration creation time and I think much of our current usage of isCjs is slightly floored. If you start Sentry via --require it will detect CJS but then the error could later occur in ESM code where require is not available. require(esm) will make this more likely.

I've seen similar in nextJs where Sentry detects CJS but nextjs is just loading instrument.js and Sentry in CJS mode. Underneath nextjs runs in ESM and uses async import to load dependencies including any cache handler which hits import-in-the-middle.

I think we need to remove isCjs entirely and gate at usages of require, module.register or anything else that is CJS only.

[timfish]

maybe we need this integration to be built to .cjs so we know it's always run in cjs mode 🤔

[timfish]

This is fine to merge. I will open another issue for my concerns once they're properly formed and tested 😂

[AbhiPrasad]

I think we need to remove isCjs entirely and gate at usages of require, module.register or anything else that is CJS only.

Yes isCjs needs to be fixed, but I figured this at least gets around the app crashing issue. We can keep iterating from here.