Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): Avoid recording long animation frame spans starting before their parent span #14186

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 5, 2024

Analogously to #14183 for long task spans, this PR ensures we don't create and attach ui.long-animation-frame spans to navigation spans/transactions if they were started before the navigation span.

Changes in this PR:

  • Check for start time of parent navigation span and don't start span long animation frame span if its start timestamp is earlier than the navigation start time stamp
  • Refactor span starting logic to use common helper function to compensate the bundle size increase
  • Add regression test that failed previously
  • Improve regression test from fix(browser): Avoid recording long task spans starting before their parent span #14183 to avoid flakes and improve the in-test navigation

@Lms24 Lms24 self-assigned this Nov 5, 2024
@Lms24 Lms24 requested review from AbhiPrasad and s1gr1d November 5, 2024 14:31
Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.76 KB - -
@sentry/browser - with treeshaking flags 21.54 KB - -
@sentry/browser (incl. Tracing) 35.2 KB +0.08% +27 B 🔺
@sentry/browser (incl. Tracing, Replay) 71.92 KB +0.03% +21 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.35 KB +0.04% +21 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.24 KB +0.03% +22 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.04 KB +0.03% +21 B 🔺
@sentry/browser (incl. Feedback) 39.9 KB - -
@sentry/browser (incl. sendFeedback) 27.4 KB - -
@sentry/browser (incl. FeedbackAsync) 32.2 KB - -
@sentry/react 25.51 KB - -
@sentry/react (incl. Tracing) 38.17 KB +0.07% +27 B 🔺
@sentry/vue 26.9 KB - -
@sentry/vue (incl. Tracing) 37.09 KB +0.07% +24 B 🔺
@sentry/svelte 22.9 KB - -
CDN Bundle 24.1 KB - -
CDN Bundle (incl. Tracing) 37.02 KB +0.07% +25 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.69 KB +0.04% +29 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.03 KB +0.04% +27 B 🔺
CDN Bundle - uncompressed 70.66 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.84 KB +0.06% +58 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.36 KB +0.03% +58 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.58 KB +0.03% +58 B 🔺
@sentry/nextjs (client) 38.26 KB +0.07% +26 B 🔺
@sentry/sveltekit (client) 35.8 KB +0.07% +25 B 🔺
@sentry/node 131.52 KB - -
@sentry/node - without tracing 95.64 KB - -
@sentry/aws-serverless 105.91 KB - -

View base workflow run

@Lms24 Lms24 merged commit fa684ab into develop Nov 6, 2024
143 checks passed
@Lms24 Lms24 deleted the lms/fix-browser-long-animation-frame-start-time branch November 6, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants