Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(types): Deprecate Request type in favor of RequestEventData #14317

Merged
merged 1 commit into from
Nov 18, 2024
Merged

ref(types): Deprecate Request type in favor of RequestEventData #14317

merged 1 commit into from
Nov 18, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 15, 2024

The type Request is very misleading and overloaded, so let's rename it to something clearer.

I opted with RequestEventData, but happy to hear other ideas as well.

Closes #14300

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad November 15, 2024 09:30
@mydea mydea self-assigned this Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.77 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.27 KB - -
@sentry/browser (incl. Tracing, Replay) 71.99 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.37 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.3 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.15 KB - -
@sentry/browser (incl. Feedback) 39.93 KB - -
@sentry/browser (incl. sendFeedback) 27.42 KB - -
@sentry/browser (incl. FeedbackAsync) 32.23 KB - -
@sentry/react 25.52 KB - -
@sentry/react (incl. Tracing) 38.23 KB - -
@sentry/vue 26.92 KB - -
@sentry/vue (incl. Tracing) 37.1 KB - -
@sentry/svelte 22.91 KB - -
CDN Bundle 24.13 KB - -
CDN Bundle (incl. Tracing) 37.05 KB - -
CDN Bundle (incl. Tracing, Replay) 71.71 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.06 KB - -
CDN Bundle - uncompressed 70.73 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.93 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.45 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.67 KB - -
@sentry/nextjs (client) 38.35 KB - -
@sentry/sveltekit (client) 35.85 KB - -
@sentry/node 134.05 KB -0.18% -244 B 🔽
@sentry/node - without tracing 96.24 KB -0.23% -224 B 🔽
@sentry/aws-serverless 106.49 KB -0.22% -236 B 🔽

View base workflow run

@mydea mydea mentioned this pull request Nov 15, 2024
Merged
@mydea mydea merged commit ef83bfc into develop Nov 18, 2024
153 checks passed
@mydea mydea deleted the fn/rename-request-type branch November 18, 2024 08:33
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Closed
onurtemizkan pushed a commit that referenced this pull request Nov 22, 2024
@mydea @onurtemizkan
ref(types): Deprecate Request type in favor of RequestEventData (#…
1347c78 
…14317)

The type `Request` is very misleading and overloaded, so let's rename it
to something clearer.

I opted with `RequestEventData`, but happy to hear other ideas as well.

Closes #14300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Request type
2 participants
@mydea @lforst