Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add disableAnrDetectionForCallback function #14359

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Nov 19, 2024

disableAnrDetectionForCallback(() => dialog.openSaveDialog());

Maybe this should just go in the Electron SDK?

I added it for Node because it may be useful outside of Electron and at least here it has access to some private variables and types.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should namespace this under anr to control the export count a little, maybe something to think about for v9.

Exporting this seems fine to me.

@AbhiPrasad
Copy link
Member

Mind fixing the merge conflicts? We can merge this in after!

@Lms24
Copy link
Member

Lms24 commented Dec 4, 2024

@timfish sorry we were to slow with merging. Would you mind resolving the conflict once more?

@timfish
Copy link
Collaborator Author

timfish commented Dec 4, 2024

Looks good to go!

@Lms24 Lms24 merged commit 20c267e into develop Dec 4, 2024
109 checks passed
@Lms24 Lms24 deleted the timfish/feat/anr-disable-callback branch December 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants