ref(flags): Refactor LaunchDarkly integration to reusable functions #14369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
changed the base branch from
develop
to
aliu/launch-darkly-integration
billyvg
changed the title
size-limit report 📦
|
billyvg
commented
Nov 19, 2024
There was a problem hiding this comment.
I imagine we'll want to use this in node/server environments as well, would it make sense to move these to core?
There was a problem hiding this comment.
I think the handler being used in the LD integration is only available for client-side js, that's why this was moved to the browser. Not sure if this will change for other integrations in the future
There was a problem hiding this comment.
Nothing in these util functions are specific to LD integration, it stores flag values to scope. It's possible for a server side implementation to re-use these functions.
chargome
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
I think the handler being used in the LD integration is only available for client-side js, that's why this was moved to the browser. Not sure if this will change for other integrations in the future
billyvg
force-pushed
the
ref-ff-launch-darkly-integration-abstraction
branch
from
a094ad5
to
d124fef
Compare
Moves core logic into re-usable functions so that we can re-use for other integrations.
billyvg
force-pushed
the
ref-ff-launch-darkly-integration-abstraction
branch
from
39583db
to
4195a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves core logic into re-usable functions so that we can re-use for other integrations.
Depends on #14207