feat(browser): Send additional LCP timing info #14372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Lms24
force-pushed
the
lms/feat-browser-lcp-data
branch
from
d2b7830 to
d0e0bac
Compare
Lms24
force-pushed
the
lms/feat-browser-lcp-data
branch
from
12e36fa to
a90c628
Compare
|
The failing tests are just NextJS canary tests (which we know currently fail but that's unrelated to this PR) and the test flake detector which times out after an hour. So this PR is ready for review. |
s1gr1d
reviewed
Nov 21, 2024
| @@ -635,6 +635,18 @@ function _setWebVitalAttributes(span: Span): void { | |||
| span.setAttribute('lcp.url', _lcpEntry.url.trim().slice(0, 200)); | |||
| } | |||
|
|
|||
| if (_lcpEntry.loadTime != null) { | |||
There was a problem hiding this comment.
Is != on purpose or do we want !== here? (also for renderTime)
There was a problem hiding this comment.
Yes, I only want to add the attribute it loadTime is not null or undefined. != null is a shorthand way of checking for that (and a bit more size efficient than !== undefined)
s1gr1d
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
loadTimeandrenderTimeattributes from the LCP performance entry to thepageloadspan. Besides being valuable information for users, this also helps us detect if LCP is potentially unreliable:Timing-Allow-Originheader was not sent in the resource response, therenderTimewill be0.Background information: The
web-vitalslibrary takes thestartTimeattribute of the LCP entry as the LCP value.startTimeis set to:renderTimeifrenderTime > 0loadTimeotherwise