feat(core): Deprecate validSeverityLevels
#14407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
size-limit report 📦
|
AbhiPrasad
approved these changes
Nov 21, 2024
mydea
reviewed
Nov 21, 2024
packages/core/src/api.ts
Outdated
| @@ -18,13 +17,21 @@ function _getIngestEndpoint(dsn: DsnComponents): string { | |||
|
|
|||
| /** Returns a URL-encoded string with auth config suitable for a query string. */ | |||
| function _encodedAuth(dsn: DsnComponents, sdkInfo: SdkInfo | undefined): string { | |||
| return urlEncode({ | |||
There was a problem hiding this comment.
hmm wait did this get confused with another PR? This is the validSeverityLevels PR here, should this be in #14406 instead? 😅
There was a problem hiding this comment.
yes 😶 I pushed all of these PRs within like 30s and messed everything up 😂
mydea
reviewed
Nov 21, 2024
mydea
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14267
Deprecates and removes internal usages of
validSeverityLevels. This is mostly unused and serves no purpose.