fix(nextjs): Only apply tracing metadata to data fetcher data when data is an object #14575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
reviewed
Dec 4, 2024
| @@ -36,7 +36,7 @@ export function wrapGetServerSidePropsWithSentry( | |||
| sentryTrace, | |||
| } = await (tracedGetServerSideProps.apply(thisArg, args) as ReturnType<typeof tracedGetServerSideProps>); | |||
|
|
|||
| if (serverSideProps && 'props' in serverSideProps) { | |||
| if (typeof serverSideProps === 'object' && 'props' in serverSideProps) { | |||
There was a problem hiding this comment.
Just to verify...do you want to include null (and other) values here? because typeof null === 'object'
You could check for serverSideProps.constructor.name === "Object" if you specifically look for an object.
There was a problem hiding this comment.
the joys of any :D If we want to make this safe I would do:
serverSideProps && typeof serverSideProps === 'object' && 'props' in serverSidePropsIf you make serverSideProps: unknown then this is what actually "works" in a type safe way, I believe.
There was a problem hiding this comment.
for some reason I fumbled this one and the errorgetinitialprops one
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14571
Technically this is unnecessary because Next.js requires data fetchers to return an object but still we don't want people thinking Sentry is the problem.