Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs)!: Remove experimental_captureRequestError #14607

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 6, 2024

Fixes #14302

Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.19 KB - -
@sentry/browser - with treeshaking flags 21.87 KB - -
@sentry/browser (incl. Tracing) 35.68 KB - -
@sentry/browser (incl. Tracing, Replay) 72.59 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.02 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.9 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.39 KB - -
@sentry/browser (incl. Feedback) 39.95 KB - -
@sentry/browser (incl. sendFeedback) 27.81 KB - -
@sentry/browser (incl. FeedbackAsync) 32.6 KB - -
@sentry/react 25.87 KB - -
@sentry/react (incl. Tracing) 38.5 KB - -
@sentry/vue 27.4 KB - -
@sentry/vue (incl. Tracing) 37.52 KB - -
@sentry/svelte 23.36 KB - -
CDN Bundle 24.36 KB - -
CDN Bundle (incl. Tracing) 37.34 KB - -
CDN Bundle (incl. Tracing, Replay) 72.21 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.56 KB - -
CDN Bundle - uncompressed 71.56 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.85 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.92 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 237.13 KB - -
@sentry/nextjs (client) 38.79 KB - -
@sentry/sveltekit (client) 36.18 KB - -
@sentry/node 162.93 KB - -
@sentry/node - without tracing 99.81 KB -0.01% -1 B 🔽
@sentry/aws-serverless 127.3 KB - -

View base workflow run

@mydea mydea force-pushed the lforst-rm-exp-cre branch from 1711436 to 94f1572 Compare December 6, 2024 10:34
@kevva
Copy link

kevva commented Dec 9, 2024

Can I ask a sort of unrelated question? How is this meant to be used? We're currently using both this and withServerActionInstrumentation but with autoInstrumentMiddleware and autoInstrumentServerFunctions turned off. But since captureRequestError also catches server action errors, doesn't it make withServerActionInstrumentation sort of unneeded? This isn't really documented anywhere so not sure what the benefit is of using one over the other.

@lforst
Copy link
Member Author

lforst commented Dec 10, 2024

@kevva withServerActionInstrumentation also tracks duration via spans and allows you to track form inputs. You should likely use both.

@lforst lforst merged commit 26119bf into v9 Dec 10, 2024
122 checks passed
@lforst lforst deleted the lforst-rm-exp-cre branch December 10, 2024 10:43
mydea pushed a commit that referenced this pull request Dec 11, 2024
mydea pushed a commit that referenced this pull request Dec 13, 2024
mydea pushed a commit that referenced this pull request Dec 13, 2024
lforst added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants