Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser)!: Remove captureUserFeedback method #14820

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

andreiborza
Copy link
Member

Use captureFeedback as a drop-in replacement instead.

Closes: #14383

Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23 KB -0.73% -171 B 🔽
@sentry/browser - with treeshaking flags 21.72 KB -0.55% -122 B 🔽
@sentry/browser (incl. Tracing) 35.54 KB -0.36% -129 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.8 KB -0.16% -113 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.23 KB -0.13% -82 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 77.21 KB -0.15% -114 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.6 KB -0.13% -116 B 🔽
@sentry/browser (incl. Feedback) 39.77 KB -0.35% -141 B 🔽
@sentry/browser (incl. sendFeedback) 27.62 KB -0.55% -154 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.38 KB -0.46% -151 B 🔽
@sentry/react 25.74 KB -0.53% -140 B 🔽
@sentry/react (incl. Tracing) 38.36 KB -0.41% -161 B 🔽
@sentry/vue 27.25 KB -0.47% -131 B 🔽
@sentry/vue (incl. Tracing) 37.41 KB -0.28% -107 B 🔽
@sentry/svelte 23.17 KB -0.63% -149 B 🔽
CDN Bundle 24.36 KB +0.43% +106 B 🔺
CDN Bundle (incl. Tracing) 35.91 KB +0.28% +102 B 🔺
CDN Bundle (incl. Tracing, Replay) 71 KB +0.12% +86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.19 KB -0.03% -23 B 🔽
CDN Bundle - uncompressed 71.41 KB +0.14% +100 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 106.88 KB +0.1% +100 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.95 KB +0.05% +100 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.82 KB -0.11% -243 B 🔽
@sentry/nextjs (client) 38.66 KB -0.33% -128 B 🔽
@sentry/sveltekit (client) 36.08 KB -0.28% -103 B 🔽
@sentry/node 157.99 KB - -
@sentry/node - without tracing 98.87 KB - -
@sentry/aws-serverless 126.6 KB - -

View base workflow run

Copy link

codecov bot commented Dec 20, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
622 3 619 296
View the top 3 failed tests by shortest run time
public-api/captureFeedback/withCaptureException/test.ts capture user feedback when captureException is called
Stack Traces | 0.195s run time
test.ts:7:11 capture user feedback when captureException is called
public-api/captureFeedback/simple_feedback/test.ts should capture simple user feedback
Stack Traces | 0.196s run time
test.ts:7:11 should capture simple user feedback
public-api/captureFeedback/withCaptureMessage/test.ts capture user feedback when captureMessage is called
Stack Traces | 1.27s run time
test.ts:7:11 capture user feedback when captureMessage is called

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some integration tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9] Remove captureUserFeedback
2 participants