Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core)!: Type sdkProcessingMetadata more strictly #14855

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat(core)!: Type sdkProcessingMetadata more strictly #14855

merged 1 commit into from
Dec 30, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 30, 2024

This ensures we use a consistent and proper type for setSdkProcessingMetadata() and related APIs.

Closes #14341

@mydea mydea requested review from lforst, chargome and s1gr1d December 30, 2024 11:09
@mydea mydea self-assigned this Dec 30, 2024
chargome
chargome approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydea mydea merged commit 6f0251d into develop Dec 30, 2024
155 checks passed
@mydea mydea deleted the fn/sdkProcessingMetadataType branch December 30, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome chargome approved these changes

@lforst lforst Awaiting requested review from lforst

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v9] Give type hints to scope.setSDKProcessingMetadata()
2 participants
@mydea @chargome