Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 7, 2025

Backport of #14895 for v8

Closes #14891

This PR updates the sync feedback integration to avoid it pulling in the
`lazyLoadIntegration` code. This is not really needed and leads to some
problems (and also bundle size increase).

For this I updated the type signature of `buildFeedbackIntegration` to
ensure that _either_ `lazyLoadIntegration` _or_ the getter functions are
provided, so we can type-safely use this.

We probably also want to backport this to v8 then.
@mydea mydea requested review from Lms24 and chargome January 7, 2025 08:37
@mydea mydea self-assigned this Jan 7, 2025
@mydea mydea requested a review from a team as a code owner January 7, 2025 08:37
Copy link
Contributor

github-actions bot commented Jan 7, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.29 KB - -
@sentry/browser - with treeshaking flags 21.96 KB - -
@sentry/browser (incl. Tracing) 35.85 KB - -
@sentry/browser (incl. Tracing, Replay) 73.09 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.48 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.4 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.34 KB -0.61% -560 B 🔽
@sentry/browser (incl. Feedback) 39.5 KB -1.35% -552 B 🔽
@sentry/browser (incl. sendFeedback) 27.89 KB - -
@sentry/browser (incl. FeedbackAsync) 32.69 KB +0.03% +9 B 🔺
@sentry/react 25.96 KB - -
@sentry/react (incl. Tracing) 38.66 KB - -
@sentry/vue 27.56 KB - -
@sentry/vue (incl. Tracing) 37.69 KB - -
@sentry/svelte 23.45 KB - -
CDN Bundle 24.49 KB - -
CDN Bundle (incl. Tracing) 37.56 KB - -
CDN Bundle (incl. Tracing, Replay) 72.75 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 78.11 KB -0.05% -35 B 🔽
CDN Bundle - uncompressed 71.93 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.42 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.5 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.6 KB -0.05% -119 B 🔽
@sentry/nextjs (client) 38.92 KB - -
@sentry/sveltekit (client) 36.36 KB - -
@sentry/node 162.8 KB - -
@sentry/node - without tracing 98.94 KB -0.01% -2 B 🔽
@sentry/aws-serverless 126.63 KB +0.01% +1 B 🔺

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants