fix(vue): Remove logError from vueIntegration
#14958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
reviewed
Jan 9, 2025
packages/vue/src/errorhandler.ts
Outdated
| @@ -30,27 +30,15 @@ export const attachErrorHandler = (app: Vue, options: VueOptions): void => { | |||
| setTimeout(() => { | |||
| captureException(error, { | |||
| captureContext: { contexts: { vue: metadata } }, | |||
| mechanism: { handled: false }, | |||
| mechanism: { handled: !!originalErrorHandler, type: 'vue-errorHandler' }, | |||
There was a problem hiding this comment.
Typically we just use the framework name as the mechanism type, so:
Suggested change
| mechanism: { handled: !!originalErrorHandler, type: 'vue-errorHandler' }, | |
| mechanism: { handled: !!originalErrorHandler, type: 'vue' }, |
We have a brief comment about this in relay, but I'll make a PR to develop to make this more clear.
There was a problem hiding this comment.
That's my "bad" - I didn't know that this was more than coincidence in the places where we set a custom type. Thanks for pointing this out and develop sounds good!
| * When set to `true`, original Vue's `logError` will be called as well. | ||
| * https://github.com/vuejs/vue/blob/c2b1cfe9ccd08835f2d99f6ce60f67b4de55187f/src/core/util/error.js#L38-L48 | ||
| */ | ||
| logErrors: boolean; |
There was a problem hiding this comment.
I wonder if there is an easy way to deprecate this in v8
There was a problem hiding this comment.
I deprecated it in this PR: #14943
s1gr1d
added a commit
that referenced
this pull request
Jan 9, 2025
AbhiPrasad
approved these changes
Jan 9, 2025
Lms24
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
logErrorand always re-throws the error when it's not handled by the user.PR for v8 (without removing
logError): #14943Logging the error has been a problem in the past already (see #7310). By just re-throwing the error we don't mess around with the initial message and stacktrace.