Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop nitro-utils package #14998

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat!: Drop nitro-utils package #14998

merged 1 commit into from
Jan 14, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 14, 2025

It is not used anymore, as we inlined the respective code into nuxt/solidstart packages for now. We can always bring it back later if needed.

@mydea mydea requested review from s1gr1d and andreiborza January 14, 2025 08:57
@mydea mydea self-assigned this Jan 14, 2025
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@mydea
Copy link
Member Author

mydea commented Jan 14, 2025

Tests failing due to #15001, I believe!

mydea added a commit that referenced this pull request Jan 14, 2025
It seems that `@types/qs` v 6.9.18 which was just released breaks this
somehow...

Noticed here: #14998
It is not used anymore, as we inlined the respective code into nuxt/solidstart packages for now. We can always bring it back later if needed.
@mydea mydea force-pushed the fn/drop-nitro-utils branch from bb9873c to b29275b Compare January 14, 2025 09:45
@mydea mydea merged commit f24ee28 into develop Jan 14, 2025
156 checks passed
@mydea mydea deleted the fn/drop-nitro-utils branch January 14, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants