Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore async exceptions when reading source files fails #1501

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

geigerzaehler
Copy link

This fixes a subtle bug where async exceptions thrown in addPrePostContext() where not caught by the try/catch block.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

This fixes a subtle bug where async exceptions thrown in `addPrePostContext()` where not caught by the try/catch block.
@kamilogorek kamilogorek merged commit 4b40c39 into getsentry:master Sep 3, 2018
@kamilogorek
Copy link
Contributor

Thanks!

@geigerzaehler geigerzaehler deleted the patch-1 branch September 3, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants