Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v8/deps): Deduplicate yarn.lock #15094

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

nwalters512
Copy link
Contributor

Backport of #14968.

The use-ts-version script was only ever used for TypeScript 3.8, so to keep things simple, I copied back the entire script and its usage from the develop branch.

@nwalters512
Copy link
Contributor Author

@AbhiPrasad tagging you in since you've been helping me with these PRs (thanks!): this is in the logs for the "Size Check" CI job output:

Error: Error updating comment. This can happen for PR's originating from a fork without write permissions.
Error: Size limit has been exceeded.

I manually reviewed the output and AFAICT this is the culprit:

  {
    "name": "@sentry/browser (incl. Tracing, Replay) - with treeshaking flags",
    "passed": false,
    "size": 68262,
    "sizeLimit": 68000
  },

Is this a blocker, or do we need to adjust the size limit? Deduping could grow the bundle if e.g. a newer version of a dependency is now being used and that version itself has a larger size.

@AbhiPrasad
Copy link
Member

Feel free to bump size limit to unblock this for now, I'll dive in deeper into the bundle to figure out what's going on

@AbhiPrasad AbhiPrasad self-assigned this Jan 20, 2025
@nwalters512
Copy link
Contributor Author

Sounds good, thanks. Size limit increased in 96c1e3f.

@nwalters512 nwalters512 marked this pull request as ready for review January 20, 2025 20:47
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 21, 2025 15:23
@AbhiPrasad AbhiPrasad merged commit 5f47fbb into getsentry:v8 Jan 21, 2025
141 checks passed
@nwalters512 nwalters512 deleted the v8-yarn-deduplicate branch January 21, 2025 15:35
andreiborza added a commit that referenced this pull request Jan 31, 2025
Backport of #14967 to v8. The diff here will shrink a lot when #15094 is
merged.

---------

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants