-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v8/deps): Deduplicate yarn.lock #15094
Conversation
@AbhiPrasad tagging you in since you've been helping me with these PRs (thanks!): this is in the logs for the "Size Check" CI job output:
I manually reviewed the output and AFAICT this is the culprit: {
"name": "@sentry/browser (incl. Tracing, Replay) - with treeshaking flags",
"passed": false,
"size": 68262,
"sizeLimit": 68000
}, Is this a blocker, or do we need to adjust the size limit? Deduping could grow the bundle if e.g. a newer version of a dependency is now being used and that version itself has a larger size. |
Feel free to bump size limit to unblock this for now, I'll dive in deeper into the bundle to figure out what's going on |
Sounds good, thanks. Size limit increased in 96c1e3f. |
Backport of #14968.
The
use-ts-version
script was only ever used for TypeScript 3.8, so to keep things simple, I copied back the entire script and its usage from thedevelop
branch.