Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node)!: Add support for Prisma v6 and drop v5 support #15120

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

AbhiPrasad
Copy link
Member

ref #14793

In v9 of the SDK, we are dropping support for Prisma v5 in favour of Prisma v6.

Prisma v6 gives us much better traces, as well as the ability to enable prisma tracing without needing to update your prisma config.

image

This PR does not enable the Prisma integration by default, I will do that in a follow up PR where we can debate if we want to do it immediately for v9, or wait a little longer for it.

@AbhiPrasad AbhiPrasad requested a review from a team January 21, 2025 21:17
@AbhiPrasad AbhiPrasad self-assigned this Jan 21, 2025
@AbhiPrasad AbhiPrasad requested review from mydea and andreiborza and removed request for a team January 21, 2025 21:17
@lforst lforst self-requested a review January 22, 2025 08:26
@lforst lforst merged commit 098f205 into develop Jan 22, 2025
146 checks passed
@lforst lforst deleted the abhi-prisma-v6 branch January 22, 2025 10:24
@spaceemotion
Copy link

Hi there! I just noticed that Sentry pulls in all the Prisma instrumentation by default - even if we don't use Prisma at all.

The README says that the package has to be installed if needed:

1. Install the `@prisma/instrumentation` package with the desired version.

During build we are now getting duplicate package warnings about opentelemetry, since @prisma/instrumentation seems to be lagging behind.

Was adding the dependency directly supposed to be a peer dependency instead?

@lforst
Copy link
Member

lforst commented Feb 24, 2025

@spaceemotion super unsatisfying but: I don't think there's anything you can do except for ignoring the warnings. As it stands we're still gonna be depending on Prisma's instrumentation package going forward because we would like to have a 0 config experience. It may change int the mid-to-long-term future but that's where we're at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants