Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node): Add pg-native integration tests #15206

Merged
merged 18 commits into from
Feb 20, 2025
Merged

Conversation

onurtemizkan
Copy link
Collaborator

Fixes: #14238

Upstream fix open-telemetry/opentelemetry-js-contrib#2563 is released on opentelemetry/instrumentation-pg@0.51.0

Also added an integration test suite to validate

Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.05 KB - -
@sentry/browser - with treeshaking flags 22.84 KB - -
@sentry/browser (incl. Tracing) 36.07 KB - -
@sentry/browser (incl. Tracing, Replay) 73.08 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.55 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.34 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.28 KB - -
@sentry/browser (incl. Feedback) 40.2 KB - -
@sentry/browser (incl. sendFeedback) 27.68 KB - -
@sentry/browser (incl. FeedbackAsync) 32.48 KB - -
@sentry/react 24.87 KB - -
@sentry/react (incl. Tracing) 37.95 KB - -
@sentry/vue 27.23 KB - -
@sentry/vue (incl. Tracing) 37.76 KB - -
@sentry/svelte 23.09 KB - -
CDN Bundle 24.25 KB - -
CDN Bundle (incl. Tracing) 36.1 KB - -
CDN Bundle (incl. Tracing, Replay) 70.94 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.11 KB - -
CDN Bundle - uncompressed 70.91 KB - -
CDN Bundle (incl. Tracing) - uncompressed 107.17 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.45 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.02 KB - -
@sentry/nextjs (client) 38.94 KB - -
@sentry/sveltekit (client) 36.48 KB - -
@sentry/node 129.25 KB - -
@sentry/node - without tracing 98.03 KB - -
@sentry/aws-serverless 107.45 KB - -

View base workflow run

Copy link

codecov bot commented Jan 28, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4550 1 4549 316
View the top 1 failed test(s) by shortest run time
Prisma ORM v5 Tests CJS - should instrument PostgreSQL queries from Prisma ORM
Stack Traces | 15.6s run time
Error: thrown: "Exceeded timeout of 15000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at .../tracing/prisma-orm-v5/test.ts:8:3
    at _dispatchDescribe (.../jest-circus/build/index.js:98:26)
    at describe (.../jest-circus/build/index.js:60:5)
    at Object.<anonymous> (.../tracing/prisma-orm-v5/test.ts:7:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1646:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1185:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:1009:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:389:16)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@onurtemizkan onurtemizkan force-pushed the onur/otel-pg-bump branch 7 times, most recently from 006de8c to 7be35e8 Compare February 3, 2025 22:15
@onurtemizkan onurtemizkan force-pushed the onur/otel-pg-bump branch 9 times, most recently from 04253c1 to 4038e76 Compare February 6, 2025 23:47
@onurtemizkan
Copy link
Collaborator Author

It seems like it's already bumped. So, I'm updating the name as this only adds tests now.

@onurtemizkan onurtemizkan changed the title fix(node): Bump opentelemetry/instrumentation-pg to 0.51.0 test(node): Add pg-native integration tests Feb 20, 2025
@AbhiPrasad
Copy link
Member

@onurtemizkan I merged in another PR that causes conflicts, mind fixing it up? Then we can merge in.

@AbhiPrasad AbhiPrasad merged commit e01a428 into develop Feb 20, 2025
147 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/otel-pg-bump branch February 20, 2025 19:21
AbhiPrasad added a commit that referenced this pull request Feb 21, 2025
AbhiPrasad added a commit that referenced this pull request Feb 21, 2025
Reverts #15206

This PR requires `libpq` for `yarn install` to be complete, so going to
revert this. Let's put this requirement into the docker image instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing postgres query spans in Remix app
3 participants