Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Handling uncaught errors in SolidStart #15245

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Jan 31, 2025

The SDK cannot currently deal with uncaught errors properly. Neither in routes nor in server actions as demonstrated by the two e2e tests in this PR.

ref: #15242

The SDK cannot currently deal with uncaught errors properly. Neither in routes
nor in server actions as demonstrated by the two e2e tests in this PR.
Copy link

codecov bot commented Jan 31, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
252 2 250 8
View the top 2 failed tests by shortest run time
uncaught.errors.server.test.ts server-side errorscaptures server action error
Stack Traces | 30s run time
uncaught.errors.server.test.ts:5:3 captures server action error
uncaught.route.error.test.ts client-side errorscaptures error thrown on click
Stack Traces | 30s run time
uncaught.route.error.test.ts:5:3 captures error thrown on click

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants