Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add links to span options #15453

Draft
wants to merge 1 commit into
base: sig/addSpan-core
Choose a base branch
from

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 20, 2025

⚠️ Merge this first: #15452

part of #14991

@s1gr1d s1gr1d mentioned this pull request Feb 20, 2025
5 tasks
@s1gr1d s1gr1d requested review from Lms24 and chargome February 20, 2025 13:33
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.05 KB added added
@sentry/browser - with treeshaking flags 22.84 KB added added
@sentry/browser (incl. Tracing) 36.13 KB added added
@sentry/browser (incl. Tracing, Replay) 73.14 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.59 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 77.39 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 90.34 KB added added
@sentry/browser (incl. Feedback) 40.2 KB added added
@sentry/browser (incl. sendFeedback) 27.68 KB added added
@sentry/browser (incl. FeedbackAsync) 32.48 KB added added
@sentry/react 24.87 KB added added
@sentry/react (incl. Tracing) 38.01 KB added added
@sentry/vue 27.29 KB added added
@sentry/vue (incl. Tracing) 37.81 KB added added
@sentry/svelte 23.09 KB added added
CDN Bundle 24.25 KB added added
CDN Bundle (incl. Tracing) 36.15 KB added added
CDN Bundle (incl. Tracing, Replay) 71 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.17 KB added added
CDN Bundle - uncompressed 70.91 KB added added
CDN Bundle (incl. Tracing) - uncompressed 107.29 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.57 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.13 KB added added
@sentry/nextjs (client) 38.99 KB added added
@sentry/sveltekit (client) 36.54 KB added added
@sentry/node 127.74 KB added added
@sentry/node - without tracing 98.03 KB added added
@sentry/aws-serverless 107.45 KB added added

Copy link

codecov bot commented Feb 20, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4583 1 4582 322
View the top 1 failed test(s) by shortest run time
express tracesSampler includes normalizedRequest data CJS correctly samples & passes data to tracesSampler
Stack Traces | 0.638s run time
Error: Caught error after test environment was torn down

Failed: Object {
  "code": "ECONNREFUSED",
  "columnNumber": undefined,
  "config": Object {
    "adapter": Array [
      "xhr",
      "http",
      "fetch",
    ],
    "env": Object {
      "Blob": null,
      "FormData": "[Function: FormData]",
    },
    "headers": Object {
      "Accept": "application/json, text/plain, */*",
      "Accept-Encoding": "gzip, compress, deflate, br",
      "User-Agent": "axios/1.7.7",
    },
    "maxBodyLength": -1,
    "maxContentLength": -1,
    "method": "get",
    "timeout": 0,
    "transformRequest": Array [
      "[Function: transformRequest]",
    ],
    "transformResponse": Array [
      "[Function: transformResponse]",
    ],
    "transitional": Object {
      "clarifyTimeoutError": false,
      "forcedJSONParsing": true,
      "silentJSONParsing": true,
    },
    "url": "http://localhost:42339/test2?q=1",
    "validateStatus": "[Function: validateStatus]",
    "xsrfCookieName": "XSRF-TOKEN",
    "xsrfHeaderName": "X-XSRF-TOKEN",
  },
  "description": undefined,
  "fileName": undefined,
  "lineNumber": undefined,
  "message": "",
  "name": "AggregateError",
  "number": undefined,
  "stack": "AggregateError: 
    at Function.Object.<anonymous>.AxiosError.from (.../lib/core/AxiosError.js:92:14)
    at RedirectableRequest.handleRequestError (.../lib/adapters/http.js:620:25)
    at RedirectableRequest.emit (node:events:524:28)
    at ClientRequest.eventHandlers.<computed> (.../node_modules/follow-redirects/index.js:49:24)
    at ClientRequest.emit (node:events:524:28)
    at emitErrorEvent (node:_http_client:104:11)
    at Socket.socketErrorListener (node:_http_client:518:5)
    at Socket.emit (node:events:524:28)
    at emitErrorNT (node:internal/streams/destroy:170:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at Axios.request (.../lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at Object.makeRequest (.../node-integration-tests/utils/runner.ts:445:78)",
  "status": undefined,
}
    at complete (.../node-integration-tests/utils/runner.ts:232:9)
    at Object.makeRequest (.../node-integration-tests/utils/runner.ts:458:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant