chore(CI): Remove Biome in favour of prettier #15461
Open
+99
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we have to re-enable some eslint rules? |
|
The eslint config hasn't been touched much in years. The thing that is missing is calling prettier in all the packages! |
|
Ok, prettier is re-enabled for TypeScript and JavaScript. Rather than run it for each package individually which is quite slow, it follows how Biome worked and runs against the entire repository at once which is much faster. Unfortunatly, prettier and Biome aren't identical in how they handle formatting so there are some changes to files. It seems that prettier more forcefully collapses things when they would have fitted all on one line. This doesn't yet enable formatting for svelte, vue, and astro files but that can be enabled later. |
timfish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never fully migrated to Biome because it didn't support all the lints we required.
Because we still have to run eslint (and prettier for some files) so there are no real gains to running Biome too.