-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Upgrade OTEL deps #15472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade OTEL deps #15472
Conversation
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
"@opentelemetry/instrumentation-nestjs-core": "0.44.0", | ||
"@opentelemetry/semantic-conventions": "^1.27.0", | ||
"@opentelemetry/instrumentation": "0.57.2", | ||
"@opentelemetry/instrumentation-nestjs-core": "0.44.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are actually not using this package in the Nest.js package. I think it's just there so we don't forget about upgrading it until this PR is merged.
For the time being, we have inlined the instrumentation in this PR.
Basically, we only changed this line: const supportedVersions = ['>=4.0.0 <12'];
But I'm not sure if it's worth it to update the inlined instrumentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it upgraded so that all the underlying deps have the same versions.
The main thing this change does is to upgrade all the packages to use https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.57.1
Other changes include:
We can think about adding Knex as a default instrumentation.