Skip to content

feat: Upgrade OTEL deps #15472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat: Upgrade OTEL deps #15472

merged 3 commits into from
Feb 24, 2025

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Feb 24, 2025

@AbhiPrasad AbhiPrasad requested a review from a team February 24, 2025 14:41
@AbhiPrasad AbhiPrasad self-assigned this Feb 24, 2025
@AbhiPrasad AbhiPrasad requested review from chargome and s1gr1d and removed request for a team February 24, 2025 14:41
Copy link
Contributor

github-actions bot commented Feb 24, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.05 KB - -
@sentry/browser - with treeshaking flags 22.84 KB - -
@sentry/browser (incl. Tracing) 36.13 KB - -
@sentry/browser (incl. Tracing, Replay) 73.14 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.59 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.39 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.34 KB - -
@sentry/browser (incl. Feedback) 40.2 KB - -
@sentry/browser (incl. sendFeedback) 27.68 KB - -
@sentry/browser (incl. FeedbackAsync) 32.48 KB - -
@sentry/react 24.87 KB - -
@sentry/react (incl. Tracing) 38.01 KB - -
@sentry/vue 27.29 KB - -
@sentry/vue (incl. Tracing) 37.81 KB - -
@sentry/svelte 23.09 KB - -
CDN Bundle 24.25 KB - -
CDN Bundle (incl. Tracing) 36.15 KB - -
CDN Bundle (incl. Tracing, Replay) 71 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.17 KB - -
CDN Bundle - uncompressed 70.91 KB - -
CDN Bundle (incl. Tracing) - uncompressed 107.29 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.57 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.13 KB - -
@sentry/nextjs (client) 39.16 KB - -
@sentry/sveltekit (client) 36.54 KB - -
@sentry/node 142.09 KB +9.94% +12.84 KB 🔺
@sentry/node - without tracing 95.52 KB -2.56% -2.5 KB 🔽
@sentry/aws-serverless 119.85 KB +11.55% +12.4 KB 🔺

View base workflow run

Copy link

codecov bot commented Feb 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4633 1 4632 328
View the top 1 failed test(s) by shortest run time
sessions/initial-scope/test.ts should start a new session with navigation.
Stack Traces | 0.398s run time
test.ts:19:11 should start a new session with navigation.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

"@opentelemetry/instrumentation-nestjs-core": "0.44.0",
"@opentelemetry/semantic-conventions": "^1.27.0",
"@opentelemetry/instrumentation": "0.57.2",
"@opentelemetry/instrumentation-nestjs-core": "0.44.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually not using this package in the Nest.js package. I think it's just there so we don't forget about upgrading it until this PR is merged.

For the time being, we have inlined the instrumentation in this PR.

Basically, we only changed this line: const supportedVersions = ['>=4.0.0 <12'];

But I'm not sure if it's worth it to update the inlined instrumentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it upgraded so that all the underlying deps have the same versions.

@AbhiPrasad AbhiPrasad merged commit 5ade42e into develop Feb 24, 2025
148 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-upgrade-otel-feb-2025 branch February 24, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants