Skip to content

fix(nextjs): Prevent wrong culprit from showing up for clientside error events #15475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

fix(nextjs): Prevent wrong culprit from showing up for clientside error events #15475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f441011
fix(nextjs): Prevent wrong culprit from showing up for clientside err…
Feb 24, 2025
88a6b84
.
Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions packages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,31 +94,32 @@ export function appRouterInstrumentNavigation(client: Client): void {
// @ts-expect-error Weird type error related to not knowing how to associate return values with the individual functions - we can just ignore
router[routerFunctionName] = new Proxy(router[routerFunctionName], {
apply(target, thisArg, argArray) {
const span = startBrowserTracingNavigationSpan(client, {
name: INCOMPLETE_APP_ROUTER_INSTRUMENTATION_TRANSACTION_NAME,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.app_router_instrumentation',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
},
});

currentNavigationSpan = span;
let transactionName = INCOMPLETE_APP_ROUTER_INSTRUMENTATION_TRANSACTION_NAME;
const transactionAttributes: Record<string, string> = {
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.app_router_instrumentation',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
};

if (routerFunctionName === 'push') {
span?.updateName(transactionNameifyRouterArgument(argArray[0]));
span?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'url');
span?.setAttribute('navigation.type', 'router.push');
transactionName = transactionNameifyRouterArgument(argArray[0]);
transactionAttributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] = 'url';
transactionAttributes['navigation.type'] = 'router.push';
} else if (routerFunctionName === 'replace') {
span?.updateName(transactionNameifyRouterArgument(argArray[0]));
span?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'url');
span?.setAttribute('navigation.type', 'router.replace');
transactionName = transactionNameifyRouterArgument(argArray[0]);
transactionAttributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] = 'url';
transactionAttributes['navigation.type'] = 'router.replace';
} else if (routerFunctionName === 'back') {
span?.setAttribute('navigation.type', 'router.back');
transactionAttributes['navigation.type'] = 'router.back';
} else if (routerFunctionName === 'forward') {
span?.setAttribute('navigation.type', 'router.forward');
transactionAttributes['navigation.type'] = 'router.forward';
}

currentNavigationSpan = startBrowserTracingNavigationSpan(client, {
name: transactionName,
attributes: transactionAttributes,
});

return target.apply(thisArg, argArray);
},
});
Expand Down
Loading