Skip to content

build(profiling-node): Fix output directory & caching #15945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
"outputs": [
"{projectRoot}/build/esm",
"{projectRoot}/build/cjs",
"{projectRoot}/build/lib/esm",
"{projectRoot}/build/lib/cjs",
"{projectRoot}/build/npm/esm",
"{projectRoot}/build/npm/cjs"
]
Expand Down
2 changes: 1 addition & 1 deletion packages/profiling-node/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
node_modules/
build/
lib/
build/
coverage/
2 changes: 1 addition & 1 deletion packages/profiling-node/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = {
},
extends: ['../../.eslintrc.js'],

ignorePatterns: ['lib/**/*', 'examples/**/*', 'vitest.config.ts'],
ignorePatterns: ['build/**/*', 'examples/**/*', 'vitest.config.ts'],
rules: {
'@sentry-internal/sdk/no-class-field-initializers': 'off',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/profiling-node/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

# compiled output
/node_modules/
/lib/
/build/

31 changes: 15 additions & 16 deletions packages/profiling-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,26 @@
"homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/profiling-node",
"author": "Sentry",
"license": "MIT",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
"types": "lib/types/index.d.ts",
"main": "build/cjs/index.js",
"module": "build/esm/index.js",
"types": "build/types/index.d.ts",
"exports": {
"./package.json": "./package.json",
".": {
"import": {
"types": "./lib/types/index.d.ts",
"default": "./lib/esm/index.js"
"types": "./build/types/index.d.ts",
"default": "./build/esm/index.js"
},
"require": {
"types": "./lib/types/index.d.ts",
"default": "./lib/cjs/index.js"
"types": "./build/types/index.d.ts",
"default": "./build/cjs/index.js"
}
}
},
"typesVersions": {
"<5.0": {
"lib/types/index.d.ts": [
"lib/types-ts3.8/index.d.ts"
"build/types/index.d.ts": [
"build/types-ts3.8/index.d.ts"
]
}
},
Expand All @@ -39,19 +39,18 @@
"access": "public"
},
"files": [
"/lib",
"/build",
"package.json",
"/scripts/prune-profiler-binaries.js"
],
"scripts": {
"clean": "rm -rf build && rm -rf lib",
"clean": "rm -rf build",
"lint": "eslint . --format stylish",
"lint:es-compatibility": "es-check es2022 ./lib/cjs/*.js && es-check es2022 ./lib/esm/*.js --module",
"lint:es-compatibility": "es-check es2022 ./build/cjs/*.js && es-check es2022 ./build/esm/*.js --module",
"fix": "eslint . --format stylish --fix",
"build": "yarn build:lib",
"build:lib": "yarn build:types && rollup -c rollup.npm.config.mjs",
"build:transpile": "yarn build:lib",
"build:types:downlevel": "yarn downlevel-dts lib/types lib/types-ts3.8 --to ts3.8",
"build": "yarn build:types && yarn build:transpile",
"build:transpile": "yarn rollup -c rollup.npm.config.mjs",
"build:types:downlevel": "yarn downlevel-dts build/types build/types-ts3.8 --to ts3.8",
"build:types": "tsc -p tsconfig.types.json && yarn build:types:downlevel",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"build:dev": "yarn clean && yarn build",
Expand Down
2 changes: 1 addition & 1 deletion packages/profiling-node/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export default makeNPMConfigVariants(
makeBaseNPMConfig({
packageSpecificConfig: {
output: {
dir: 'lib',
dir: 'build',
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
// set preserveModules to false because for profiling we actually want
Expand Down
2 changes: 1 addition & 1 deletion packages/profiling-node/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"compilerOptions": {
"module": "esnext",
"lib": ["es2018"],
"outDir": "lib",
"outDir": "build",
"types": ["node"]
},
"include": ["src/**/*"]
Expand Down
2 changes: 1 addition & 1 deletion packages/profiling-node/tsconfig.types.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "lib/types",
"outDir": "build/types",
"types": ["node"]
},
"files": ["src/index.ts"]
Expand Down
Loading