feat(remix): Vendor in opentelemetry-instrumentation-remix
#16145
+399
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/vendor-in-remix-otel
branch
3 times, most recently
from
d736081 to
6c80c8e
Compare
onurtemizkan
force-pushed
the
onur/vendor-in-remix-otel
branch
from
6c80c8e to
bb95f29
Compare
andreiborza
approved these changes
May 2, 2025
packages/remix/src/utils/utils.ts
Outdated
Comment on lines
29
to
30
| if (formDataKeys[key] === false) { | ||
| return; |
There was a problem hiding this comment.
m: This is already covered by the outer if right?
There was a problem hiding this comment.
Oops, yes. Updated
| /* eslint-disable max-lines */ | ||
| /* eslint-disable jsdoc/require-jsdoc */ | ||
|
|
||
| // Vendored and modified from: |
There was a problem hiding this comment.
q: Could you briefly describe what was modified in the PR description please?
There was a problem hiding this comment.
Updated the PR description 👍
andreiborza
approved these changes
May 5, 2025
s1gr1d
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15739
Removed Remix v1-related instrumentation code from the original implementation while vendoring in.
Also, FormData entries for manual instrumentation are aligned with OTEL use.
Resolves: [Remix] Only attach keys defined in
captureActionFormDataKeys#16140