Skip to content

feat(replay): Extend default list for masking with aria-label #16192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chargome
Copy link
Member

@chargome chargome commented May 5, 2025

closes #16176

@chargome chargome self-assigned this May 5, 2025
@chargome chargome requested a review from a team as a code owner May 5, 2025 09:53
Copy link
Contributor

github-actions bot commented May 5, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.32 KB - -
@sentry/browser - with treeshaking flags 23.13 KB - -
@sentry/browser (incl. Tracing) 36.98 KB - -
@sentry/browser (incl. Tracing, Replay) 74.16 KB +0.02% +12 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.5 KB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 78.81 KB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.6 KB +0.01% +4 B 🔺
@sentry/browser (incl. Feedback) 39.71 KB - -
@sentry/browser (incl. sendFeedback) 27.94 KB - -
@sentry/browser (incl. FeedbackAsync) 32.7 KB - -
@sentry/react 25.12 KB - -
@sentry/react (incl. Tracing) 38.95 KB - -
@sentry/vue 27.55 KB - -
@sentry/vue (incl. Tracing) 38.73 KB - -
@sentry/svelte 23.34 KB - -
CDN Bundle 24.52 KB - -
CDN Bundle (incl. Tracing) 36.99 KB - -
CDN Bundle (incl. Tracing, Replay) 72.04 KB +0.02% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.35 KB +0.02% +9 B 🔺
CDN Bundle - uncompressed 71.57 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.41 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.71 KB +0.01% +13 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.23 KB +0.01% +13 B 🔺
@sentry/nextjs (client) 40.55 KB - -
@sentry/sveltekit (client) 37.45 KB - -
@sentry/node 143.45 KB -0.01% -1 B 🔽
@sentry/node - without tracing 96.54 KB - -
@sentry/aws-serverless 120.86 KB - -

View base workflow run

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add some kind of test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria-labels should probably be scrubbed
2 participants