feat(browser): Add option to ignore mark and measure spans
#16443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
bcoe
approved these changes
Jun 2, 2025
s1gr1d
approved these changes
Jun 2, 2025
| @@ -149,7 +149,22 @@ export interface BrowserTracingOptions { | |||
| * | |||
| * Default: [] | |||
| */ | |||
| ignoreResourceSpans: Array<string>; | |||
| ignoreResourceSpans: Array<'resouce.script' | 'resource.css' | 'resource.img' | 'resource.other' | string>; | |||
There was a problem hiding this comment.
yeah, realized we only made this addition in browsermetrics.ts rather than the user-facing option. Luckily not breaking :D
| * | ||
| * Default: [] - By default, all `mark` and `measure` entries are sent as spans. | ||
| */ | ||
| ignoreMeasureSpans: Array<string | RegExp>; |
There was a problem hiding this comment.
As this not only applies to the measure spans...should we call this ignorePerformanceAPISpans or ignoreWebPerformanceSpans? 🤔
No hard opinion on that though as my proposed name might be too wide in its description.
There was a problem hiding this comment.
I had exactly the same feeling. Let's make a decision fast, as I agree the name doesn't really include mark spans.
There was a problem hiding this comment.
And this is how we could extend this if people need granular options:
ignorePerformanceAPISpans: {
mark:
measure:
...
}There was a problem hiding this comment.
Renamed the option to ignorePerformanceApiSpans in ae2cfb0. Thanks for bringing this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignorePerformanceApiSpansoption that matches span names ofmarkandmeasurespans to a given array or RegExpUsage:
closes #16441