-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Expand how vercel ai input/outputs can be set #16455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
}; | ||
} | ||
const client = getCurrentScope().getClient(); | ||
const shouldRecordImportAndExports = client?.getIntegrationByName(INTEGRATION_NAME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: shouldn't this rather be named
const shouldRecordImportAndExports = client?.getIntegrationByName(INTEGRATION_NAME) | |
const shouldRecordInputsAndOutputs = client?.getIntegrationByName(INTEGRATION_NAME) |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done with 71e7546
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super-l: Is there a reason for this file? No strong feelings, so feel free to disregard but I'd rather avoid a constants file with one export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put this here to avoid circular imports (instrumentation
-> index
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh that's of course fine! sorry, didn't notice it
e23162f
to
71e7546
Compare
sendDefaultPii
is true
❌ Unsupported file format
|
resolves #16452
Based on feedback, we want to enable attaching prompts (inputs/outputs) to vercel AI spans if
sendDefaultPii
istrue
.We also add new integration options to the Vercel AI integration that allows you to override this.
Usage: