feat(react-router): Export wrappers for server loaders and actions #16481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Jun 4, 2025
Comment on lines
53
to
57
| root.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITE, args.request.url); | ||
| root.setAttributes({ | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITE]: `${args.request.method} ${pathname}`, | ||
| }); |
There was a problem hiding this comment.
2 questions:
- have you tried using the
updateSpanNamehelper instead of the overwrite attribute? Not sure if 1:1 the same just noticed that we have a similar pattern in the SDK already. - I guess there's no way right now to get a parameterized route from the arguments or some other available context?
There was a problem hiding this comment.
- Yes, the overriding happens quite late, the
SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITEattribute was the only one working consistently - Not ootb but we can figure this out in a follow up PR, as we have access to the manifest :)
AbhiPrasad
reviewed
Jun 4, 2025
This was referenced Jun 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports two new functions for wrapping server actions and loaders:
wrapServerAction+wrapServerLoader.Since #16327 is blocking our automatic instrumentation, these two wrappers can be used to selectively trace actions and loaders on the server.
I have also added a new e2e that basically tests the existing functionality without the
ReactRouterServerintegration, but using manual wrappers instead.