feat(flags): add node support for generic featureFlagsIntegration and move utils to core #16585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt, sveltekit (has *)
…sentry-javascript into aliu/move-ffs-to-core
…try-javascript into aliu/move-ffs-to-core
aliu39
changed the title
2 tasks
size-limit report 📦
|
AbhiPrasad
approved these changes
Jun 16, 2025
chargome
approved these changes
Jun 17, 2025
billyvg
reviewed
Jun 17, 2025
| @@ -1,11 +1,11 @@ | |||
| import { expect } from '@playwright/test'; | |||
| import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core'; | |||
There was a problem hiding this comment.
Is this _INTERNAL pattern common in the codebase?
There was a problem hiding this comment.
It is starting with logs - we don't really have a better way to do this because of the way @sentry/core is structured atm.
We could do subpath exports, but that breaks horribly for some bundlers (esbuild 😢)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
featureFlagsIntegrationis an integration to manually buffer feature flags on evaluation, and capture them in event contexts and span attributes. This PR moves it from browser to core, as well as the shared functionality/utils of all FF integrations (no browser specific logic).Browser exports and functionality is unchanged. Per @AbhiPrasad 's recommendation I've manually exported the integration in all the packages
zodErrorsIntegrationis exported. Note many backend pkgs use a wildcard (*) export from node.TODO:
Part of