feat(core): Add support for x-forwarded-host and x-forwarded-proto headers
#16687
+218
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
andreiborza
approved these changes
Jun 23, 2025
Comment on lines
+208
to
+210
| 'x-forwarded-proto': 'https', | ||
| }, | ||
| protocol: 'http', |
There was a problem hiding this comment.
l: Could you also add one test case for the reverse (protocol: https but forwarded: http) just to test that this isn't just accidentally passing because we always have https?
andreiborza
pushed a commit
that referenced
this pull request
Jun 23, 2025
…` headers (#16687) Adds support for [x-forwarded-host](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Forwarded-Host) (host forwarding) and [x-forwarded-proto](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Forwarded-Proto) (protocol forwarding). This is useful when using proxies. Closes #16671 Support for this was also added [in this PR for Next.js](#16500)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for x-forwarded-host (host forwarding) and x-forwarded-proto (protocol forwarding).
This is useful when using proxies.
Closes #16671
Support for this was also added in this PR for Next.js