-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node-core): Add node-core SDK #16745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreiborza
wants to merge
7
commits into
develop
Choose a base branch
from
ab/node-core
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+14,532
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf84c54
to
9fd7337
Compare
size-limit report 📦
|
610c5cc
to
8b31e19
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dfab0e0
to
3d127cf
Compare
andreiborza
commented
Jul 3, 2025
|
||
setTimeout(() => { | ||
process.exit(); | ||
}, 20000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timfish I had to increase the timeout here to get these to pass. Could you have a look why that might be?
I'm wondering if the OTel init outside of Sentry.init has something to do with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
@sentry/node-core
SDK and refactors@sentry/node
to build on it. It provides the core functionality of the Node SDK with a few key differences@opentelemetry/instrumentation-X
)@sentry/node
APIs (minus the OpenTelemetry instrumentations)When to Use Each
This SDK is not intended to be used by most users directly (similarly to
@sentry/core
). It provides core functionality and makes it possible to be used in setups where OpenTelemetry dependencies that do not match those we set up in the more opinionated@sentry/node
SDK.Use
@sentry/node-core
when:Use
@sentry/node
when:Example setup
Sentry should be initialized as early in your app as possible. It is essential that you call
Sentry.init
before yourequire any other modules in your application, otherwise any auto-instrumentation will not work.
You also need to set up OpenTelemetry, if you prefer not to, consider using the
@sentry/node
SDK instead.You need to create a file named
instrument.js
that imports and initializes Sentry: