Skip to content

fix(nuxt): Ensure order of plugins is consistent #16798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 3, 2025

Noticed #16783 in the nuxt-3-min test, that the plugins are not consistently run apparently. In that test, the client integrations plugin was run before the client config plugin, leading to the client not existing yet, and thus not adding the browser tracing integration.

This PR changes this to ensure we have a consistent order of these plugins.

Noticed #16783 in the nuxt-3-min test, that the plugins are not consistently run apparently. In that test, the client integrations plugin was run before the client config plugin, leading to the client not existing yet, and thus not adding the browser tracing integration.

This PR changes this to ensure we have a consistent order of these plugins.
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm, did this just silently fail before?

@mydea mydea force-pushed the fn/ensure-nuxt-plugin-order branch from 6281550 to 9fedd69 Compare July 3, 2025 12:15
@mydea
Copy link
Member Author

mydea commented Jul 3, 2025

I think it only fails on specific versions of nuxt or vue or something like this, only the nuxt-3-min test failed on the branch without that 🤔 basically it was just a bit indeterministic, this should be fine hopefully xD

@mydea mydea merged commit d0a68fb into develop Jul 3, 2025
35 of 36 checks passed
@mydea mydea deleted the fn/ensure-nuxt-plugin-order branch July 3, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants