feat(core): Prepend vercel ai attributes with vercel.ai.X
#16908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
Lms24 and
andreiborza
and removed request for
a team
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-rename-vercel-ai
branch
from
e18b503 to
d794cfb
Compare
Lms24
approved these changes
Jul 11, 2025
packages/core/src/utils/vercel-ai.ts
Outdated
| // Change attributes namespaced with `ai.X` to `vercel.ai.X` | ||
| for (const key of Object.keys(attributes)) { | ||
| if (key.startsWith('ai.')) { | ||
| renameAttributeKey(attributes, key, `vercel.ai.${key.slice(3)}`); |
There was a problem hiding this comment.
l: instead of slicing, can we just preprend vercel.${key}?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/getsentry/issue/JS-663
Categorizing the attributes this way helps us differentiate between the ai attributes added by vercel compared to the otel semantic conventions.