Skip to content

fix(svelte): Do not insert preprocess code in script module in Svelte 5 (#17113) #17114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

fix(svelte): Do not insert preprocess code in script module in Svelte 5 (#17113) #17114

merged 2 commits into from
Jul 22, 2025

Conversation

richardjelinek-fastest
Copy link
Contributor

No description provided.

@Lms24 Lms24 linked an issue Jul 22, 2025 that may be closed by this pull request
Don't insert Svelte preprocessor code in script module in Svelte 5. #17113
Closed
@Lms24 Lms24 self-requested a review July 22, 2025 08:41
@Lms24 Lms24 self-assigned this Jul 22, 2025
Lms24
Lms24 reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for submitting this PR! Gonna let CI run through it but I'm confident we can merge this soon.

@Lms24 Lms24 merged commit 8289440 into getsentry:develop Jul 22, 2025
36 checks passed
@HazAT HazAT mentioned this pull request Jul 22, 2025
Merged
Lms24 added a commit that referenced this pull request Jul 22, 2025
@HazAT @Lms24
chore: Add external contributor to CHANGELOG.md (#17122)
549ca39 
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #17114

Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
Lms24 added a commit that referenced this pull request Jul 22, 2025
@richardjelinek-fastest @Lms24
fix(svelte): Do not insert preprocess code in script module in Svelte…
b887811 
… 5 (#17114)

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@Lms24 Lms24 mentioned this pull request Jul 22, 2025
Merged
Lms24 added a commit that referenced this pull request Jul 24, 2025
@Lms24 @richardjelinek-fastest
fix(v9/svelte): Do not insert preprocess code in script module in Sve…
a5259dc 
…lte 5 (#17124)

Backport of #17114

---------

Co-authored-by: Richard Jelínek <131378741+richardjelinek-fastest@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Jul 31, 2025
Closed
This was referenced Sep 29, 2025
Closed
Closed
This was referenced Oct 7, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@Lms24 Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't insert Svelte preprocessor code in script module in Svelte 5.

2 participants

@richardjelinek-fastest @Lms24