Skip to content

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 14, 2025

Closes #17065

@s1gr1d s1gr1d requested a review from Lms24 August 14, 2025 09:18
@s1gr1d s1gr1d changed the title test(solidstart): Don't rely on flushing for lowQualityTransactionFilter feat(sveltekit): Align build time options with shared type Aug 14, 2025
Copy link
Contributor

github-actions bot commented Aug 14, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.17 kB - -
@sentry/browser - with treeshaking flags 22.75 kB - -
@sentry/browser (incl. Tracing) 40.16 kB - -
@sentry/browser (incl. Tracing, Replay) 78.5 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.27 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 83.19 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 95.4 kB - -
@sentry/browser (incl. Feedback) 40.9 kB - -
@sentry/browser (incl. sendFeedback) 28.82 kB - -
@sentry/browser (incl. FeedbackAsync) 33.76 kB - -
@sentry/react 25.91 kB - -
@sentry/react (incl. Tracing) 42.15 kB - -
@sentry/vue 28.66 kB - -
@sentry/vue (incl. Tracing) 41.97 kB - -
@sentry/svelte 24.2 kB - -
CDN Bundle 25.76 kB - -
CDN Bundle (incl. Tracing) 40.04 kB - -
CDN Bundle (incl. Tracing, Replay) 76.32 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 81.79 kB - -
CDN Bundle - uncompressed 75.28 kB - -
CDN Bundle (incl. Tracing) - uncompressed 118.51 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 233.6 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 246.37 kB - -
@sentry/nextjs (client) 44.15 kB - -
@sentry/sveltekit (client) 40.6 kB - -
@sentry/node-core 49.84 kB - -
@sentry/node 151.13 kB -0.01% -1 B 🔽
@sentry/node - without tracing 91.73 kB -0.01% -1 B 🔽
@sentry/aws-serverless 105.18 kB -0.01% -1 B 🔽

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review! Took a look at the new type definitions and the migrations. Looks good to me! Thanks for cleaning this up!

Heads-up: This likely needs a rebase after #17423

@s1gr1d s1gr1d force-pushed the sig/align-build-time-options-sveltekit branch from 67088e8 to b43f94f Compare September 12, 2025 07:50
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,839 - 8,806 +0%
GET With Sentry 1,274 14% 1,273 +0%
GET With Sentry (error only) 6,095 69% 6,109 -0%
POST Baseline 1,200 - 1,218 -1%
POST With Sentry 465 39% 508 -8%
POST With Sentry (error only) 1,067 89% 1,064 +0%
MYSQL Baseline 3,319 - 3,367 -1%
MYSQL With Sentry 386 12% 467 -17%
MYSQL With Sentry (error only) 2,694 81% 2,724 -1%

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SvelteKit]: Align build-time bundler plugin options
2 participants