feat(cloudflare): Add instrumentPrototypeMethods option to instrument RPC methods for DurableObjects
#17424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
andreiborza
force-pushed
the
ab/durable-objects-rpc
branch
from
119eabd to
d231d2a
Compare
andreiborza
changed the title
instrumentPrototypeMethods option to instrument RPC methods for DurableObjects
andreiborza
force-pushed
the
ab/durable-objects-rpc
branch
from
d5132d9 to
adcd67d
Compare
chargome
reviewed
Aug 27, 2025
andreiborza
force-pushed
the
ab/durable-objects-rpc
branch
from
88cac5d to
9401c0f
Compare
andreiborza
force-pushed
the
ab/durable-objects-rpc
branch
from
9401c0f to
122d1ca
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
andreiborza
force-pushed
the
ab/durable-objects-rpc
branch
from
122d1ca to
dcffbfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
The RPC receiver does not implement the method "METHOD_NAME errorerrors by wrapping methods and putting them back on the prototype.Added an option
instrumentPrototypeMethodsto opt into wrapping RPC methods. These are potentially expensive to wrap because each invocation wraps so we provide an option to either enable this as a whole or pass method names that should be wrapped.Also removes the flag to not record spans because no spans were collected ever. I think this is related to connected traces not working correctly for the SDK? cc @AbhiPrasad.
Closes: #17127