feat(core): Add replay id to logs #17563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
Lms24 and
RulaKhaled
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -150,6 +151,9 @@ export function _INTERNAL_captureLog( | |||
| setLogAttribute(processedLogAttributes, 'sentry.sdk.name', name); | |||
| setLogAttribute(processedLogAttributes, 'sentry.sdk.version', version); | |||
|
|
|||
| const replay = client.getIntegrationByName<Integration & { getReplayId: () => string }>('Replay'); | |||
| setLogAttribute(processedLogAttributes, 'sentry.replay_id', replay?.getReplayId()); | |||
There was a problem hiding this comment.
Bug: Optional Chaining Fails When Method Undefined
The optional chaining replay?.getReplayId() only checks if replay exists. If replay is present but getReplayId is undefined, calling it will throw a runtime TypeError, potentially disrupting log capturing.
Lms24
approved these changes
Sep 8, 2025
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/sentry-docs#14838
resolves https://linear.app/getsentry/issue/JS-901/add-sentryreplay-id-attribute-to-javascript-sdk-logs
resolves #17520