Skip to content

ref(node): Add mechanism to errors captured via connect and koa integrations #17579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2025
Merged

ref(node): Add mechanism to errors captured via connect and koa integrations #17579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b897e28
ref(node): Add mechanism to errors captured from `connect` error midd…
Lms24 Jul 31, 2025
9ffc41c
ref(node): Add `mechanism` to errors captured from koa error handler
Lms24 Jul 31, 2025
e16866c
ref(node): Add mechanism to errors captured via connect and koa integ…
Lms24 Sep 9, 2025
a16ae6b
fix tests
Lms24 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dev-packages/e2e-tests/test-applications/node-connect/tests/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ test('Sends correct error event', async ({ baseURL }) => {
const errorEvent = await errorEventPromise;

expect(errorEvent.exception?.values).toHaveLength(1);
expect(errorEvent.exception?.values?.[0]?.value).toBe('This is an exception');
const exception = errorEvent.exception?.values?.[0];
expect(exception?.value).toBe('This is an exception');

expect(exception?.mechanism).toEqual({
type: 'auto.middleware.connect',
handled: false,
});

expect(errorEvent.request).toEqual({
method: 'GET',
Expand Down
8 changes: 7 additions & 1 deletion dev-packages/e2e-tests/test-applications/node-koa/tests/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ test('Sends correct error event', async ({ baseURL }) => {
const errorEvent = await errorEventPromise;

expect(errorEvent.exception?.values).toHaveLength(1);
expect(errorEvent.exception?.values?.[0]?.value).toBe('This is an exception with id 123');
const exception = errorEvent.exception?.values?.[0];

expect(exception?.value).toBe('This is an exception with id 123');
expect(exception?.mechanism).toEqual({
type: 'auto.middleware.koa',
handled: false,
});

expect(errorEvent.request).toEqual({
method: 'GET',
Expand Down
7 changes: 6 additions & 1 deletion packages/node/src/integrations/tracing/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ export const connectIntegration = defineIntegration(_connectIntegration);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
function connectErrorMiddleware(err: any, req: any, res: any, next: any): void {
captureException(err);
captureException(err, {
mechanism: {
handled: false,
type: 'auto.middleware.connect',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Span Origin Mismatch for Exception Capture

The mechanism type should align with SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN when a span wraps the captureException call. Connect spans use 'auto.http.otel.connect' as their origin, so the mechanism type should be 'auto.http.otel.connect' instead of 'auto.middleware.connect'.

Fix in Cursor Fix in Web

},
});
next(err);
}

Expand Down
7 changes: 6 additions & 1 deletion packages/node/src/integrations/tracing/koa.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,12 @@ export const setupKoaErrorHandler = (app: { use: (arg0: (ctx: any, next: any) =>
try {
await next();
} catch (error) {
captureException(error);
captureException(error, {
mechanism: {
handled: false,
type: 'auto.middleware.koa',
},
});
throw error;
}
});
Expand Down
Loading