Skip to content

ref(node): Inline types imported from shimmer #17597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

ref(node): Inline types imported from shimmer #17597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions packages/node/src/integrations/tracing/firebase/otel/patches/firestore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
ATTR_SERVER_PORT,
} from '@opentelemetry/semantic-conventions';
import type { SpanAttributes } from '@sentry/core';
import type { unwrap as shimmerUnwrap, wrap as shimmerWrap } from 'shimmer';
import type { FirebaseInstrumentation } from '../firebaseInstrumentation';
import type {
AddDocType,
Expand All @@ -37,6 +36,11 @@ import type {
WithFieldValue,
} from '../types';

// Inline minimal types used from `shimmer` to avoid importing shimmer's types directly.
// We only need the shape for `wrap` and `unwrap` used in this file.
type ShimmerWrap = (target: any, name: string, wrapper: (...args: any[]) => any) => void;
type ShimmerUnwrap = (target: any, name: string) => void;

/**
*
* @param tracer - Opentelemetry Tracer
Expand All @@ -47,8 +51,8 @@ import type {
export function patchFirestore(
tracer: Tracer,
firestoreSupportedVersions: string[],
wrap: typeof shimmerWrap,
unwrap: typeof shimmerUnwrap,
wrap: ShimmerWrap,
unwrap: ShimmerUnwrap,
config: FirebaseInstrumentationConfig,
): InstrumentationNodeModuleDefinition {
// eslint-disable-next-line @typescript-eslint/no-empty-function
Expand Down Expand Up @@ -102,8 +106,8 @@ export function patchFirestore(
function wrapMethods(
// eslint-disable-next-line @typescript-eslint/no-explicit-any
moduleExports: any,
wrap: typeof shimmerWrap,
unwrap: typeof shimmerUnwrap,
wrap: ShimmerWrap,
unwrap: ShimmerUnwrap,
tracer: Tracer,
firestoreSpanCreationHook: FirestoreSpanCreationHook,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand All @@ -121,7 +125,7 @@ function wrapMethods(
function unwrapMethods(
// eslint-disable-next-line @typescript-eslint/no-explicit-any
moduleExports: any,
unwrap: typeof shimmerUnwrap,
unwrap: ShimmerUnwrap,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
): any {
for (const method of ['addDoc', 'getDocs', 'setDoc', 'deleteDoc']) {
Expand Down