Skip to content

Conversation

msonnb
Copy link
Contributor

@msonnb msonnb commented Sep 17, 2025

Enables the Lambda extension by default when using the Lambda layer

@msonnb msonnb self-assigned this Sep 17, 2025
/**
* If proxying Sentry events through the Sentry Lambda extension should be enabled. Defaults to `true` when using the AWS Lambda layer.
*/
enableLambdaExtension?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would go with another option, as this does not really control enabling the extension (e.g. you cannot simply set this to true when using the npm package, right?)

Maybe something like:

useLayerExtension?: boolean

or similar, to make it clear that is related to layers and just using it, not enabling it...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that makes more sense 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I maybe also create an issue for distributing a separate layer with only the extension in it? then npm users could benefit as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd leave this for now, if we get this request in the future we can always follow up - for now this is simple enough I'd say :D

@msonnb msonnb marked this pull request as ready for review September 18, 2025 07:17
Copy link
Contributor

github-actions bot commented Sep 18, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,326 - 9,262 +1%
GET With Sentry 1,433 15% 1,394 +3%
GET With Sentry (error only) 6,281 67% 5,999 +5%
POST Baseline 1,200 - 1,179 +2%
POST With Sentry 556 46% 560 -1%
POST With Sentry (error only) 1,060 88% 1,061 -0%
MYSQL Baseline 3,385 - 3,310 +2%
MYSQL With Sentry 452 13% 421 +7%
MYSQL With Sentry (error only) 2,702 80% 2,677 +1%

View base workflow run

cursor[bot]

This comment was marked as outdated.

@msonnb msonnb requested a review from andreiborza September 18, 2025 07:38
Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff :)

@msonnb msonnb removed their assignment Sep 19, 2025
@mydea mydea changed the title chore(aws): Remove experimental flag for Lambda extension feat(aws): Enable Lambda extension by default when using the Lamba layer Sep 24, 2025
@andreiborza andreiborza merged commit 678d6e8 into develop Sep 24, 2025
60 checks passed
@andreiborza andreiborza deleted the ms/aws-extension-remove-experimental branch September 24, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants