-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(aws): Enable Lambda extension by default when using the Lamba layer #17684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/aws-serverless/src/init.ts
Outdated
/** | ||
* If proxying Sentry events through the Sentry Lambda extension should be enabled. Defaults to `true` when using the AWS Lambda layer. | ||
*/ | ||
enableLambdaExtension?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would go with another option, as this does not really control enabling the extension (e.g. you cannot simply set this to true when using the npm package, right?)
Maybe something like:
useLayerExtension?: boolean
or similar, to make it clear that is related to layers and just using it, not enabling it...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that makes more sense 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I maybe also create an issue for distributing a separate layer with only the extension in it? then npm users could benefit as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd leave this for now, if we get this request in the future we can always follow up - for now this is simple enough I'd say :D
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff :)
Enables the Lambda extension by default when using the Lambda layer