-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
build: Update to typescript 5.8.0 #17710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
17e7562 to
fa8a726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to adjust
"typesVersions": {
"<5.0": {
"build/npm/types/index.d.ts": [
"build/npm/types-ts3.8/index.d.ts"
]
}
},
in package.json? Unless I'm missing something, users using e.g. TS 5.2 would not get the downleveled types but might run into issues with newer TS version syntax.
Yeah, you are right I suppose! Will adjust this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot to ✅
This updates the TS version we use to 5.8.0.
We still downlevel to 3.8 so this should not be breaking (even if we were to use newer features eventually), downlevel-dts will fail/or our tests anyhow if we use some features that cannot be downlevelled.
Note
Upgrade TypeScript to 5.8 across the repo, adjust tsconfigs and deps, and fix minor type issues to satisfy stricter checks.
typescriptto~5.8.0and update version guard inscripts/verify-packages-versions.js.yarn.lockand package constraints; add new e2e appdev-packages/e2e-tests/test-applications/generic-ts5.0.moduleResolution: "Node16"in multipletsconfig.jsonfiles and test configs.@types/nodeand include"node"intypeswhere needed (e.g., Hydrogen test app).Map.keys().next().value.handlers[type].push(handler)), and minor TS cleanups in profiling/LRU/debug-id utilities.@ts-expect-errorforcfinit property; avoid unused CF type import.appDirPath.Written by Cursor Bugbot for commit 5ec5959. This will update automatically on new commits. Configure here.