fix(nextjs): fix createRouteManifest with basePath #17838
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Looks good already, would you mind also reflecting this in one of the e2e-tests ( |
If I apply a basePath to the existing E2E test application, it seems that all transaction assertions and URL paths in the test code would need to include the basePath prefix. Could you provide some guidance on whether it would be better to add tests directly to the existing app, or to create a separate app with basePath enabled for testing purposes? |
|
We can move this into a new next-15-basepath test. Feel free to ping me if I should take this over! |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #17838 Co-authored-by: chargome <20254395+chargome@users.noreply.github.com>
fix getsentry#17837 add basePath prefix to createRouteManifest closes getsentry#17837 --------- Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#17838 Co-authored-by: chargome <20254395+chargome@users.noreply.github.com>
3 participants
fix #17837
add basePath prefix to createRouteManifest
closes #17837