Skip to content

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Oct 6, 2025

This resolves the issue that occurs when an extra navigation transaction is created after a prematurely ended pageload transaction in React Router lazy routes.

This apparently occurs when there's a long-running pageload with lazy-routes (after fetching assets, there are multiple potentially long-running API calls happening).

This causes the pageload transaction to prematurely end, even before the fully parameterized transaction name is resolved. The reason is that there can be a POP event emitted, which we subscribe to create a navigation transaction. This ends the ongoing pageload transaction before its name is updated with a resolved parameterized route path, and starts a navigation transaction, which contains the remaining spans that were supposed to be a part of the pageload transaction.

This fix makes sure the initial POP events are not necessarily treated as navigation pointers, which should fix both:

  • Duplicate / extra navigation transactions having a part of pageload spans.
  • Remaining wildcards in the pageload transaction names

@onurtemizkan onurtemizkan force-pushed the onur/react-router-long-running-pageload-guard branch from c5b63b9 to b3027fd Compare October 6, 2025 11:21
@onurtemizkan onurtemizkan marked this pull request as ready for review October 6, 2025 12:14
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Any way we can test this in e2e?

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,373 - 8,903 +5%
GET With Sentry 1,378 15% 1,367 +1%
GET With Sentry (error only) 6,233 66% 6,204 +0%
POST Baseline 1,193 - 1,208 -1%
POST With Sentry 514 43% 526 -2%
POST With Sentry (error only) 1,068 90% 1,069 -0%
MYSQL Baseline 3,403 - 3,350 +2%
MYSQL With Sentry 511 15% 438 +17%
MYSQL With Sentry (error only) 2,810 83% 2,715 +3%

View base workflow run

cursor[bot]

This comment was marked as outdated.

@onurtemizkan onurtemizkan force-pushed the onur/react-router-long-running-pageload-guard branch from 68e2702 to 5608b63 Compare October 9, 2025 13:14
@onurtemizkan
Copy link
Collaborator Author

@chargome - I updated the PR with edge case handling + E2E tests

@onurtemizkan onurtemizkan force-pushed the onur/react-router-long-running-pageload-guard branch from ec0a205 to 1fb8a6d Compare October 15, 2025 11:37
@chargome chargome self-assigned this Oct 15, 2025
@chargome chargome merged commit fc64c47 into develop Oct 15, 2025
91 checks passed
@chargome chargome deleted the onur/react-router-long-running-pageload-guard branch October 15, 2025 11:51
timfish pushed a commit that referenced this pull request Oct 15, 2025
This resolves the issue that occurs when an extra `navigation`
transaction is created after a prematurely ended `pageload` transaction
in React Router lazy routes.

This apparently occurs when there's a long-running pageload with
lazy-routes (after fetching assets, there are multiple potentially
long-running API calls happening).

This causes the `pageload` transaction to prematurely end, even before
the fully parameterized transaction name is resolved. The reason is that
there can be a `POP` event emitted, which we subscribe to create a
`navigation` transaction. This ends the ongoing `pageload` transaction
before its name is updated with a resolved parameterized route path, and
starts a `navigation` transaction, which contains the remaining spans
that were supposed to be a part of the `pageload` transaction.

This fix makes sure the initial `POP` events are not necessarily treated
as `navigation` pointers, which should fix both:

- Duplicate / extra `navigation` transactions having a part of
`pageload` spans.
- Remaining wildcards in the `pageload` transaction names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants