feat(tracemetrics)!: Update types #17907
Open
+85
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
changed the title
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Bug: Unused Functions Cause Compilation Errors
The estimateMetricSizeInBytes, estimateLogSizeInBytes, and estimatePrimitiveSizeInBytes functions seem accidentally committed. They are unused, unrelated to the PR's purpose, and cause compilation errors due to undefined types (Metric, Log, Primitive) and the isPrimitive function. Furthermore, their array size estimation logic accesses value[0] without checking for empty arrays and assumes homogeneous element types.
AbhiPrasad
reviewed
Oct 14, 2025
| const spanId = span ? span.spanContext().spanId : undefined; | ||
|
|
||
| if (!traceId) { | ||
| DEBUG_BUILD && debug.warn('[Metric] No trace ID available, will not send metric.'); |
There was a problem hiding this comment.
We don't do this for logs. When can this ever happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.