Skip to content

Conversation

@chargome
Copy link
Member

@chargome chargome commented Oct 22, 2025

Next 16 was released

With that proxy files run per default on nodejs.

This PR

  • Updates the tests to run on next 16 (non-beta)
  • Adds support for handling middleware transactions in the node part of the sdk

closes #18006
closes #18005
closes #18008

@chargome chargome self-assigned this Oct 22, 2025
@chargome chargome requested review from aliu39, andreiborza and logaretm and removed request for aliu39 October 22, 2025 08:26
cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are timing out and don't seem to be hitting the server, is that expected?

@chargome
Copy link
Member Author

No, something has changed in between beta and stable release, the proxy invocations are not sending any spans atm – currently investigating

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,797 - 9,475 -7%
GET With Sentry 1,366 16% 1,349 +1%
GET With Sentry (error only) 6,071 69% 6,020 +1%
POST Baseline 1,180 - 1,189 -1%
POST With Sentry 506 43% 513 -1%
POST With Sentry (error only) 1,043 88% 1,072 -3%
MYSQL Baseline 3,285 - 3,320 -1%
MYSQL With Sentry 478 15% 431 +11%
MYSQL With Sentry (error only) 2,686 82% 2,688 -0%

View base workflow run

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to also have a middleware test that still runs on edge.

@chargome chargome changed the title test(nextjs): Update nextjs 16 tests feat(nextjs): Support node runtime on proxy files Oct 23, 2025
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Test Code Cluttered by Debugging Statements

A console.log debugging statement was accidentally committed to the test code. It outputs detailed transaction event information, which clutters test console output.

Fix in Cursor Fix in Web

@chargome
Copy link
Member Author

created vercel/next.js#85261 to track the error behaviour in proxy files

@chargome chargome merged commit 152b9d4 into develop Oct 23, 2025
380 of 383 checks passed
@chargome chargome deleted the cg-next-16 branch October 23, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support node runtime in proxy/middleware nextjs-16 (canary) Test Failed nextjs-16 (canary-webpack) Test Failed

3 participants