-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Support node runtime on proxy files #17995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are timing out and don't seem to be hitting the server, is that expected?
|
No, something has changed in between beta and stable release, the proxy invocations are not sending any spans atm – currently investigating |
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to also have a middleware test that still runs on edge.
|
created vercel/next.js#85261 to track the error behaviour in proxy files |
Next 16 was released
With that proxy files run per default on nodejs.
This PR
closes #18006
closes #18005
closes #18008