Skip to content

Conversation

@JPeer264
Copy link
Member

There were 2 major changes:

  • auto.console.logging -> auto.log.console
  • auto.logging.* -> auto.log.*

This can go in already, I am just not sure if this should be a breaking change or a minor bump, since theoretically dashboards or bookmarked searches/groupings would be failing.

(closes #17900)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,839 - 8,670 +2%
GET With Sentry 1,328 15% 1,343 -1%
GET With Sentry (error only) 5,953 67% 6,020 -1%
POST Baseline 1,183 - 1,173 +1%
POST With Sentry 496 42% 499 -1%
POST With Sentry (error only) 1,047 89% 1,047 -
MYSQL Baseline 3,240 - 3,280 -1%
MYSQL With Sentry 407 13% 425 -4%
MYSQL With Sentry (error only) 2,641 82% 2,670 -1%

View base workflow run

@JPeer264 JPeer264 changed the title feat: align sentry origin with documentation feat: Align sentry origin with documentation Oct 22, 2025
@JPeer264 JPeer264 requested review from a team, AbhiPrasad, andreiborza and stephanie-anderson and removed request for a team and stephanie-anderson October 22, 2025 13:15
@JPeer264 JPeer264 marked this pull request as ready for review October 22, 2025 13:16
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is a breaking change, but I think we are fine to merge this in as the behaviour is more correct.

It is very unlikely that users will be relying on this value for dashboards/alerts, but we can always ask a product team (like telemetry experience) to do a redash query to check.

@JPeer264 JPeer264 merged commit 39f85b3 into develop Oct 23, 2025
191 of 194 checks passed
@JPeer264 JPeer264 deleted the jp/align-origin branch October 23, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure the JavaScript SDK sets sentry.origin for Structured Logs according to the documentation

2 participants