-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(nuxt): Wait for the dev port to be available #18736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+20
−2
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The script uses
nc -zto check for an open port, butncis not installed in the CI environment (ubuntu-24.04), causing the check to fail silently and wait for a full 30-second timeout.Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The bash script
nuxt-start-dev-server.bashusesnc -zwithin awhileloop to check if the dev server port is available. However, thenetcat(nc) utility is not installed by default on the CI runner's operating system,ubuntu-24.04. Whenncis not found, the command fails with exit code 127. The loop condition! nc -z ...evaluates this failure astrue, causing the loop to always run for its full 30-second duration, regardless of the server's actual status. This introduces a mandatory 30-second delay and can lead to flaky test failures if tests begin before the server is truly ready.💡 Suggested Fix
Replace the
nc -zcommand with a more reliable method that does not depend on a non-default utility. For instance, the script already useslsof -i :$PORTin other places, which is more likely to be available. Alternatively, add a step to the CI workflow to installnetcat(sudo apt-get install -y netcat-openbsd) before the script is run.🤖 Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID:
8338389