added support for commonjs modules

[zeevl]

Hey there,

This PR adds support for commonjs modules, browserify etc, sometimes used in environments where the 'window' object isn't available, but JSON is.

Steve

[mattrobenolt]

What's wrong with window.JSON here? window is referring to this. Which you can see in the _footer.js ending closure. Wouldn't that context be correct in your case?

[zeevl]

In browserify (and commonjs in general i think?) this refers to the module, not the window.. so in this case window is just an empty object. removing the window qualifier seemed like a much less invasive change than renaming the initial function parameter..

[zeevl]

fyi, here's the browserify require code:

require = (function e(t, n, r) {
    function s(o, u) {
        if (!n[o]) {
            if (!t[o]) {
                var a = typeof require == "function" && require;
                if (!u && a) return a(o, !0);
                if (i) return i(o, !0);
                throw new Error("Cannot find module '" + o + "'")
            }
            var f = n[o] = {
                exports: {}
            };
            t[o][0].call(f.exports, function(e) {
                var n = t[o][1][e];
                return s(n ? n : e)
            }, f, f.exports, e, t, n, r)
        }
        return n[o].exports
    }
    var i = typeof require == "function" && require;
    for (var o = 0; o < r.length; o++) s(r[o]);
    return s
})

[clayzermk1]

👍 can confirm that this is necessary to get this working.

[mattrobenolt]

Definitely remove the changes in dist/*. I compile those when I publish releases. It makes patches really messy.

[clayzermk1]

👍 This patch got browserify working for me.

[mattrobenolt]

We can't make this change. This is very significantly different in behavior.

(JSON && JSON.stringify) will now raise a ReferenceError instead of returning undefined as window.JSON would.

[mattrobenolt]

Superseded by #261